fabric: reproduction completeRoot called for suspended component update #35262
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that when we suspend a component in fabric react and in that component a state update occurs, that we still will call
completeRoot.This has performance implications, as
completeRootwill call into c++ and invokeShadowTree::commit.I think that when a suspended component has a state update and we still show the very same fallback component, then there should be no
completeRootcall, as technically, nothing has changed about the UI output.I believe that this is a bug with in react-reconciler / react fabric
How did you test this change?
This PR merely adds a test case that demonstrates that this seems to be broken, to raise the discussion if this needs to be fixed.