This repository was archived by the owner on Feb 1, 2025. It is now read-only.
Fix class support inside generators#408
Merged
benjamn merged 5 commits intofacebook:masterfrom Jul 23, 2021
Merged
Conversation
nicolo-ribaudo
commented
Feb 19, 2021
nicolo-ribaudo
force-pushed
the
fix-class
branch
from
acec059 to
5fe834c
Compare
1 task
nicolo-ribaudo
force-pushed
the
fix-class
branch
from
5fe834c to
8230894
Compare
JLHwung
approved these changes
Apr 19, 2021
Assuming the presence of leaping children by passing true is a safe/conservative strategy, but we can reduce unnecessary explosion in the common case when neither the superclass expression nor any computed class property names contain yield expressions or other "leaping" nodes.
Contributor
|
Thanks for diving into this, and sorry for the long wait @nicolo-ribaudo! While attempting to add a few more tests, I think I discovered a bug in Since this seems to be an upstream bug, I don't think it needs to hold up the release of these changes. |
Contributor
|
Just published these changes to npm as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes are more supported than generators, so it's possible that Babel users only compile generators:
Compiling generators inside uncompiled classes is already supported (generator methods), this PR adds support for uncompiled classes inside generators.
Fixes #407