Support building under /build/ directories#250
Draft
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Draft
Support building under /build/ directories#250travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
Github PR 247[0] changed the way that wangle chose which headers to install. As part of this, certain directories, for example `/build/`, were filtered out. Unfortunately this filtering is performed on the absolute path of the source code. If wangle is cloned underneath any directory which matches one of the filtered directories, then all the header files will be filtered out and no headers installed. Fix this by changing the initial list to be relative to the source directory such that the filtering cannot mistakenly match on paths outside the wangle source tree. [0] facebook#247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github PR 247[0] changed the way that wangle chose which headers to install. As part of this, certain directories, for example
/build/, were filtered out.Unfortunately this filtering is performed on the absolute path of the source code. If wangle is cloned underneath any directory which matches one of the filtered directories, then all the header files will be filtered out and no headers installed.
Fix this by changing the initial list to be relative to the source directory such that the filtering cannot mistakenly match on paths outside the wangle source tree.
[0] #247