Skip to content
This repository was archived by the owner on Sep 12, 2018. It is now read-only.

for issue #41 and #39 and #40#42

Open
codeVerySlow wants to merge 1 commit intofacebookarchive:masterfrom
codeVerySlow:patch-1
Open

for issue #41 and #39 and #40#42
codeVerySlow wants to merge 1 commit intofacebookarchive:masterfrom
codeVerySlow:patch-1

Conversation

@codeVerySlow
Copy link

@codeVerySlow codeVerySlow commented May 26, 2017

this is for issue #41 #39 #40
the torch7 had Add a keepdim parameter for reduction functions over a single dimension.For detail torch/torch7@c5e5487
so that commit make thpp can't compile.

the torch7 had Add a keepdim parameter for reduction functions over a single dimension.For detail torch/torch7@c5e5487
so that commit make thpp can't compile.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@codeVerySlow codeVerySlow changed the title for issue #41 and #39 for issue #41 and #39 and #40 May 26, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@huyn
Copy link

huyn commented Oct 30, 2017

solved my problem, thanks

@gbolin
Copy link

gbolin commented Feb 26, 2018

@codeVerySlow dear friend, I am still a little confused, how to compile thpp? which part code needs to be modified? wait for your reply, many thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants