Skip to content

Conversation

@ezzak
Copy link
Contributor

@ezzak ezzak commented Sep 4, 2025

This one was a doozy

  1. For downloads: Where file picker is supported use it, otherwise fallback to using an anchor tag
  2. Add the file picker approach to the new violations tab src/js/background/historyManager.ts
  3. For downloading the local code: Do not pipe every file we grab through a compression stream, this makes it very difficult to combine these streams later on in a readable way, just clone the response and store it. src/js/content/contentUtils.ts
  4. Collect all the chunks for the archive, put them in a ReadableStream, pipe it through a compression stream, and pipe it to writeable file handle steam. Before we were building a stream for every chunk and delimiter and trying to pipe them all together which is very hard to reason about src/js/content/downloadArchive.ts
  5. Typescript version bump to support Response.getBytes()

Test all download functionalities on Chrome + Firefox

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
Copy link
Contributor

@rich-hansen rich-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rich-hansen rich-hansen merged commit 44548d2 into facebookincubator:main Sep 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants