Skip to content

Reverting ucache_bench gen updates #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmadelyoussef wants to merge 1 commit into
base: v2-beta
Choose a base branch
from
Open

Reverting ucache_bench gen updates #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ucache_bench/protocol/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ set(PROTOCOL_HEADERS
gen/UcacheBenchMessages-inl.h
gen/UcacheBenchRouteHandleIf.h
gen/UcacheBenchRouterInfo.h
gen/UcacheBenchRouterInfoFwd.h
gen/UcacheBenchRouterStats.h
gen/UcacheBenchRoutingGroups.h
gen/UcacheBenchServer.h
Expand Down
123 changes: 116 additions & 7 deletions packages/ucache_bench/protocol/gen/UcacheBench.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,61 @@ namespace cpp2 facebook.ucachebench.thrift
namespace py3 facebook.ucachebench.thrift
namespace hack ucachebench

@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

"
},
}
struct UcacheBenchRequestCommon {
1: optional i64 productId
2: optional string bucketId
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

"
},
}
struct UcacheBenchReplyCommon {
1: carbon.ui32 replySourceBitMask
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbGetRequest {
Expand All @@ -44,7 +89,20 @@ struct UcbGetRequest {
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbGetReply {
Expand All @@ -59,7 +117,20 @@ struct UcbGetReply {
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbSetRequest {
Expand All @@ -72,7 +143,20 @@ struct UcbSetRequest {
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbSetReply {
Expand All @@ -86,7 +170,20 @@ struct UcbSetReply {
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbDeleteRequest {
Expand All @@ -97,7 +194,20 @@ struct UcbDeleteRequest {
}
@thrift.DeprecatedUnvalidatedAnnotations{
items = {
"cpp.virtual": "1"
"cpp.methods": "
template <class V>
void visitFields(V&& v);
template <class V>
void visitFields(V&& v) const;

template <class Writer>
void serialize(Writer&& writer) const;

void deserialize(carbon::CarbonProtocolReader& reader);

",
"cpp.virtual": "1"

},
}
struct UcbDeleteReply {
Expand All @@ -108,4 +218,3 @@ struct UcbDeleteReply {
3: string message
4: i16 appSpecificErrorCode
}

Loading