Skip to content

Migrate deprecated_terse_writes from thrift_cpp2_options to field-level @cpp.DeprecatedTerseWrite #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iahs wants to merge 1 commit into
base: v2-beta
Choose a base branch
from
Open

Migrate deprecated_terse_writes from thrift_cpp2_options to field-level @cpp.DeprecatedTerseWrite #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/ucache_bench/protocol/gen/UcacheBench.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ struct UcacheBenchRequestCommon {
2: optional string bucketId
}
struct UcacheBenchReplyCommon {
@cpp.DeprecatedTerseWrite
1: carbon.ui32 replySourceBitMask
}
@thrift.DeprecatedUnvalidatedAnnotations{
Expand All @@ -39,7 +40,9 @@ struct UcacheBenchReplyCommon {
struct UcbGetRequest {
@thrift.Mixin
-1: UcacheBenchRequestCommon ucacheBenchRequestCommon
@cpp.DeprecatedTerseWrite
1: carbon.IOBufKey key
@cpp.DeprecatedTerseWrite
2: carbon.ui64 flags
}
@thrift.DeprecatedUnvalidatedAnnotations{
Expand All @@ -50,10 +53,14 @@ struct UcbGetRequest {
struct UcbGetReply {
@thrift.Mixin
-1: UcacheBenchReplyCommon ucacheBenchReplyCommon
@cpp.DeprecatedTerseWrite
1: carbon_result.Result result
2: optional carbon.IOBuf value
@cpp.DeprecatedTerseWrite
3: carbon.ui64 flags
@cpp.DeprecatedTerseWrite
4: string message
@cpp.DeprecatedTerseWrite
5: i16 appSpecificErrorCode
6: optional i32 exptime
}
Expand All @@ -65,9 +72,13 @@ struct UcbGetReply {
struct UcbSetRequest {
@thrift.Mixin
-1: UcacheBenchRequestCommon ucacheBenchRequestCommon
@cpp.DeprecatedTerseWrite
1: carbon.IOBufKey key
@cpp.DeprecatedTerseWrite
2: i32 exptime
@cpp.DeprecatedTerseWrite
3: carbon.ui64 flags
@cpp.DeprecatedTerseWrite
4: carbon.IOBuf value
}
@thrift.DeprecatedUnvalidatedAnnotations{
Expand All @@ -78,10 +89,15 @@ struct UcbSetRequest {
struct UcbSetReply {
@thrift.Mixin
-1: UcacheBenchReplyCommon ucacheBenchReplyCommon
@cpp.DeprecatedTerseWrite
1: carbon_result.Result result
@cpp.DeprecatedTerseWrite
2: carbon.ui64 flags
@cpp.DeprecatedTerseWrite
3: carbon.IOBuf value
@cpp.DeprecatedTerseWrite
4: string message
@cpp.DeprecatedTerseWrite
5: i16 appSpecificErrorCode
}
@thrift.DeprecatedUnvalidatedAnnotations{
Expand All @@ -92,7 +108,9 @@ struct UcbSetReply {
struct UcbDeleteRequest {
@thrift.Mixin
-1: UcacheBenchRequestCommon ucacheBenchRequestCommon
@cpp.DeprecatedTerseWrite
1: carbon.IOBufKey key
@cpp.DeprecatedTerseWrite
2: carbon.ui64 flags
}
@thrift.DeprecatedUnvalidatedAnnotations{
Expand All @@ -103,9 +121,13 @@ struct UcbDeleteRequest {
struct UcbDeleteReply {
@thrift.Mixin
-1: UcacheBenchReplyCommon ucacheBenchReplyCommon
@cpp.DeprecatedTerseWrite
1: carbon_result.Result result
@cpp.DeprecatedTerseWrite
2: carbon.ui64 flags
@cpp.DeprecatedTerseWrite
3: string message
@cpp.DeprecatedTerseWrite
4: i16 appSpecificErrorCode
}

Loading