fix: correct unzip filename typo in README experiment logs section#18
fix: correct unzip filename typo in README experiment logs section#18voidborne-d wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
|
Hi @voidborne-d! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| zip -s 0 outputs_os_parts.zip --out unsplit_logs.zip | ||
| unzip unsplit_outputs.zip | ||
| unzip unsplit_logs.zip | ||
| ``` |



Fixes #13 (partially)
Problem
The README instructs users to extract experiment logs with:
The first command creates
unsplit_logs.zip, but the second command tries to unzipunsplit_outputs.zip— which does not exist. Users following these instructions will get a "file not found" error.Fix
Changed
unzip unsplit_outputs.zip→unzip unsplit_logs.zipto match the output filename from the previous command.Note: Issue #13 also reports that the archive files are Git LFS pointers (133-135 bytes each) rather than actual data. This PR fixes the command typo; the LFS issue may need separate attention (e.g., uploading actual files or providing an alternative download link).