Open
Conversation
|
you have I think you would need to update the name, or change the module name. The first is easier, but the second might be a better long term solution, as it would make using it in other projects more clear, i.e., from imagebind import ...is probably more obvious than from models import ...this is what I did in my fork of imagebind: https://github.com/chrisaddy/ImageBind All said, thanks for opening this PR, definitely want to get this in a pip installable format! |
Author
|
Hi @chrisaddy Strange, I was able to use it without any problems, I have some projects that depend on my fork and they are working correctly. The only difference is that I had to add the following lines to the pyproject file: packages = [
{ include = "data.py" },
{ include = "models" }
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request setups Poetry build tool for ImageBind, allowing it's usage as dependency in poetry projects.
Changes
models/*anddata)