Open
Conversation
meta-cla
bot
added
the
CLA Signed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| @info("Preparing simulation object...") | ||
| num_voxels = sim.Nx * sim.Ny * sim.Nz | ||
| @info("Preparing simulation object ($(sim.Nx)×$(sim.Ny)×$(sim.Nz) = $(num_voxels) voxels)...") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @info("Preparing simulation object ($(sim.Nx)×$(sim.Ny)×$(sim.Nz) = $(num_voxels) voxels)...") | |
| @info( | |
| "Preparing simulation object ($(sim.Nx)×$(sim.Ny)×$(sim.Nz) = $(num_voxels) voxels)..." | |
| ) |
Comment on lines
+193
to
+195
| @info("Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s " * | ||
| "($(round(mcells_per_s, digits=1)) MVoxels/s overall, " * | ||
| "$(round(steady_rate, digits=1)) MVoxels/s after warmup)") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @info("Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s " * | |
| "($(round(mcells_per_s, digits=1)) MVoxels/s overall, " * | |
| "$(round(steady_rate, digits=1)) MVoxels/s after warmup)") | |
| @info( | |
| "Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s " * | |
| "($(round(mcells_per_s, digits=1)) MVoxels/s overall, " * | |
| "$(round(steady_rate, digits=1)) MVoxels/s after warmup)" | |
| ) |
| "($(round(mcells_per_s, digits=1)) MVoxels/s overall, " * | ||
| "$(round(steady_rate, digits=1)) MVoxels/s after warmup)") | ||
| else | ||
| @info("Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s ($(round(mcells_per_s, digits=1)) MVoxels/s)") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @info("Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s ($(round(mcells_per_s, digits=1)) MVoxels/s)") | |
| @info( | |
| "Simulation complete: $(total_steps) steps in $(round(elapsed, digits=3))s ($(round(mcells_per_s, digits=1)) MVoxels/s)" | |
| ) |
…amples Add detailed timing to prepare_simulation! (per-phase: init_geometry, init_boundaries, add_sources, init_fields, init_monitors) and to run() (total steps, elapsed time, MVoxels/s overall and after 50-step warmup). Augment all 6 example scripts to run twice with fresh simulation objects: once cold (includes JIT compilation) and once warm, to separate algorithmic cost from compilation overhead. Plotting is done only once at the end.
Two new documents in docs/: - ROADMAP.md: Three-layer architecture (Frontend, Graph Compiler, Engine Backend) organizing 32+ feature gaps identified by comparing Khronos against Meep, Tidy3D, and fdtdx. Each feature specifies priority tier (P0-P3), implementation guidance, code references, and scope estimates. - EXAMPLES.md: 49 proposed examples mapped against 33 Meep examples, 199 Tidy3D notebooks, and 5 fdtdx examples. Includes 13 scaling and performance benchmarks (9 buildable now), cross-solver coverage matrix, and phased implementation plan aligned with the roadmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.