Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
garawalid
left a comment
garawalid
left a comment
There was a problem hiding this comment.
I think you forget to copy the project to the docker image.
Also, you need to use the Sort multi-line arguments. See Best practices for writing Dockerfiles
|
|
||
| LABEL maintainer "Siddharth Yadav <sedflix@gmail.com>" | ||
|
|
||
| RUN apt-get update && conda install -y jupyter scipy matplotlib scikit-learn faiss-gpu -c pytorch && conda clean --packages --yes |
There was a problem hiding this comment.
You forget to clean the Advanced Package Tool.
You can add apt-get clean && rm -rf /var/lib/apt/lists/*
|
|
||
| RUN apt-get update && conda install -y jupyter scipy matplotlib scikit-learn faiss-gpu -c pytorch && conda clean --packages --yes | ||
|
|
||
| CMD ["bash"] |
There was a problem hiding this comment.
I think it is better to start Jupyter by default, so users can see the demo notebook demo.ipynb.
| @@ -0,0 +1,2 @@ | |||
| data | |||
| dumped | |||
There was a problem hiding this comment.
Could you please explain why you are using .dockerignore
3 participants
Added Dockerfile for GPU. It uses pytorch 0.4.1.