This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Support word analogy score computation for other languages#74
Open
harpaj wants to merge 1 commit intofacebookresearch:mainfrom
Open
Support word analogy score computation for other languages#74harpaj wants to merge 1 commit intofacebookresearch:mainfrom
harpaj wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Contributor
|
Hello, thanks for the PR, Could you add the download of the fastText French, Hindi and Polish word analogy files in the get_evaluation.sh script https://github.com/facebookresearch/MUSE/blob/master/data/get_evaluation.sh#L18-L22 such that this fix works for these languages? Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the word analogy score computation is artificially restricted to English, without any apparent reason.
While currently the
get_evaluationscript only downloads the English dataset, others can be found for example here from Fasttext for French, Hindi and Polish and here (in slightly different format) for Finnish.This PR makes it easier to work with these datasets by detecting if the
questions-words.txtfile exists.