This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Making the dictionary evaluation optional when using the unsupervised method.#81
Open
abdullah-alnahas wants to merge 2 commits intofacebookresearch:mainfrom
Open
Making the dictionary evaluation optional when using the unsupervised method.#81abdullah-alnahas wants to merge 2 commits intofacebookresearch:mainfrom
abdullah-alnahas wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Allow users to only use unsupervised evaluation methods if no dictionary is available. Indeed, that should be the default in 'unsupervised.py' script because one could have used 'supervised.py' otherwise.
Allow users to only use unsupervised evaluation methods if no dictionary is available. Indeed, that should be the default in 'unsupervised.py' script because one could have used 'supervised.py' otherwise.
abdullah-alnahas
changed the title
oserikov
added a commit
to NIS-2018-CROSS-M/MUSE
that referenced
this pull request
Feb 12, 2019
oserikov
added a commit
to NIS-2018-CROSS-M/MUSE
that referenced
this pull request
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello MUSE developers :)
I am using 'unsupervised.py' script to align two embedding spaces, but I don't have a parallel dictionary. However, in the current code base it's mandatory to provide a parallel dictionary for evaluation. So, I thought it would be better to make the parallel dictionary optional in the 'unsupervised.py' script.
What do you think?
Thanks ;)