patch: minor fix in q value networks#120
Closed
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:patch-2
Closed
patch: minor fix in q value networks#120neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom neuralsorcerer:patch-2
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:patch-2
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
Contributor
|
@rodrigodesalvobraz merged this pull request in 4ddce21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
CNNQValueMultiHeadNetwork.get_q_valuesmethod now checkslen(action_batch.shape)when deciding whether to squeeze the returned tensor instead of usinglen(action_batch).Why?
len(action_batch)returned the batch size rather than the number of dimensions, causing incorrect squeezing behavior and potentially wrong output shapes.