refactor: refinements in utils and associated functions#121
Closed
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:refactor-util
Closed
refactor: refinements in utils and associated functions#121neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom neuralsorcerer:refactor-util
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:refactor-util
Conversation
Contributor
|
@rodrigodesalvobraz has imported this pull request. If you are a Meta employee, you can view this in D78998902. |
Contributor
|
@ayushj240 merged this pull request in 9de0995. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ActivationTypeandLossTypefor type safety.xavier_init_weightsfunction for linear layers.ActivationTypefor clarity.Why these changes?
utils.pyi.e. (Enums andxavier_init_weights), so decided to refactor according to it.