Skip to content

fix: corrected NeuralBandit, TensorBasedReplayBuffer and import path in test_serialization for code-coverage in CI/CD#123

Closed
neuralsorcerer wants to merge 4 commits intofacebookresearch:mainfrom
neuralsorcerer:fix-1
Closed

fix: corrected NeuralBandit, TensorBasedReplayBuffer and import path in test_serialization for code-coverage in CI/CD#123
neuralsorcerer wants to merge 4 commits intofacebookresearch:mainfrom
neuralsorcerer:fix-1

Conversation

@neuralsorcerer
Copy link
Contributor

Change:

  • Updated import path from from pearl.test.unit.with_pytorch.test_agent import TestAgentWithPyTorch to from test.unit.with_pytorch.test_agent import TestAgentWithPyTorch fixing code-coverage issue in CI/CD.
  • Since test folder is outside pearl, it makes sense.
image

Why?
image

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4ddce21). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage        ?   83.99%           
=======================================
  Files           ?      188           
  Lines           ?     9817           
  Branches        ?        0           
=======================================
  Hits            ?     8246           
  Misses          ?     1571           
  Partials        ?        0           
Flag Coverage Δ
unittests 83.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neuralsorcerer neuralsorcerer changed the title fix: import path in test_serialization fix: import path in test_serialization for code-coverage in CI/CD Aug 1, 2025
@neuralsorcerer
Copy link
Contributor Author

Latest change:

  • Corrected NeuralBandit to reshape action-state features before model evaluation, ensuring values have the right dimensions.
  • Adjusted action processing in TensorBasedReplayBuffer so scalar actions don’t create spurious extra dimensions.

Why?
image
fixed the above issue

@neuralsorcerer neuralsorcerer changed the title fix: import path in test_serialization for code-coverage in CI/CD fix: corrected NeuralBandit, TensorBasedReplayBuffer and import path in test_serialization for code-coverage in CI/CD Aug 1, 2025
@neuralsorcerer neuralsorcerer closed this by deleting the head repository Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants