This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fixing Logical Errors and Removing "TODO REMOVE" code#201
Open
matawoo wants to merge 5 commits intofacebookresearch:mainfrom
Open
Fixing Logical Errors and Removing "TODO REMOVE" code#201matawoo wants to merge 5 commits intofacebookresearch:mainfrom
matawoo wants to merge 5 commits intofacebookresearch:mainfrom
Conversation
matawoo
commented
Jul 20, 2021
matawoo
commented
- Fixing a Logical error in "read_video" that incorrectly breaks the loop if "i" is less than the limit, leaving the frame array empty.
- Removing code that removes the first "input_video_skip", effectively leaving the visualisations unsynchronised as the points would be ahead of the video by "input_video_skip" frames.
Removing incorrectly uploaded files from the Init Push
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.