This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Updated installation instructions and examples#25
Open
ShahRutav wants to merge 5 commits intofacebookresearch:vmoens-patch-1from
Open
Updated installation instructions and examples#25ShahRutav wants to merge 5 commits intofacebookresearch:vmoens-patch-1from
ShahRutav wants to merge 5 commits intofacebookresearch:vmoens-patch-1from
Conversation
moving examples to readme from get_started
update readme examples with torchrl updates. to track bug on MultiaSyncDataCollector with agenthive: facebookresearch#23
vikashplus
reviewed
Jan 19, 2024
| variants={ | ||
| "obs_keys": [ | ||
| "hand_jnt", | ||
| "qpos", # TODO: Check if this is correct |
Contributor
There was a problem hiding this comment.
@ShahRutav good catch on this.
The hand_jnt doesn't exist. qpos seems like the right choice.
Ideally, this should have all DoFs of the agent but not the object. Since there is no object in these scene qpos corresponds to the right thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues -