Skip to content

Conversation

@Mox301
Copy link

@Mox301 Mox301 commented Nov 21, 2025

Summary

This PR implements the Adaptive Sampling logic described in Algorithm 2 and Appendix B.1 of the paper.

Previously, the _deepthink_online method generated the entire trace budget in a single batch after warmup. This implementation updates the logic to generate traces iteratively, checking for consensus ($\beta \ge \tau$) before proceeding, ensuring the model stops generation early when a confident consensus is reached.

Changes

  • Modified deepconf/wrapper.py:
    • Updated _deepthink_online to replace bulk generation with a while loop.
    • Implemented the consensus check $\frac{V(\hat{a})}{\sum V(a)} \ge \tau$.
    • Added consensus_threshold (default 0.95 ) and adaptive_step_size (default 1 to strictly follow Appendix B.1 logic) to the deepthink interface.

Motivation

The paper describes "Online Thinking" as a dynamic process that halts trace generation once consensus is reached to save tokens. The previous implementation lacked this iterative check, generating the full total_budget regardless of consensus. This change aligns the codebase with the paper's efficiency claims (e.g., Figure 6).

Test Plan

Verified using the existing examples/example_online.py.

@meta-cla
Copy link

meta-cla bot commented Nov 21, 2025

Hi @Mox301!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Nov 21, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 21, 2025
@Mox301 Mox301 marked this pull request as draft November 21, 2025 14:21
@Mox301 Mox301 marked this pull request as ready for review November 21, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant