Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

fix: replace np.product with np.prod#355

Merged
mmuckley merged 1 commit intofacebookresearch:mainfrom
osbm:main
Jan 21, 2025
Merged

fix: replace np.product with np.prod#355
mmuckley merged 1 commit intofacebookresearch:mainfrom
osbm:main

Conversation

@osbm
Copy link
Contributor

@osbm osbm commented Jan 19, 2025

Using the old keyword raises errors when used with 2.x numpy versions.

@facebook-github-bot
Copy link

Hi @osbm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 19, 2025
Copy link
Contributor

@mmuckley mmuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution, @osbm!

@mmuckley mmuckley merged commit 91f2df4 into facebookresearch:main Jan 21, 2025
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants