bennaaym/graphviz_support: bug fixed | README updated with examples

[bennaaym]

Description

This is an update of the LabgraphGraphviz extension. The PR adds the following :

• Fix a small bug that appears sometimes when the graph contains a group( the bug was mainly caused by the wrong usage of Python Set.pop() method, which may give different output for the same input)
• Add examples on how to use the generate_graphviz function
• Fix package issues (import graphviz_support module)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

validation/testing

• Tested on graph examples that include a group unit

Checklist:

• Have you added tests that prove your fix is effective or that this feature works?
• New and existing unit tests pass locally with these changes?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

[fzchriha]

Hey @bennaaym great job on these examples, and thank you so much for adding them. I just wanted to point out a small bug, I encountered when trying to run generate_graphviz.py, see line 174

When I tried debugging it, it turned out my output_file was /Users/fatimazahra.chriha/Desktop/mlh/spring2022/labgraph/extensions/graphviz_support/graphviz_support/examples/output/simple_viz.svg

So when running filename, format = output_file.split('.') it resulted in a list of 3 elements instead of 2 I solved it by replacing line 174 by

split_list = output_file.split('/')
last_ele = split_list.pop().split('.')
format = last_ele[1]
filename = '/'.join(split_list) + '/' + last_ele[0] 

Just wanted to give you a heads up, awesome work!

[bennaaym]

Hello, @fzchriha thank you for your feedback. I have noticed that bug and I fixed it (please check the PR update). I like your solution, however, I think using "os.path.splitext()" will be an easier option. Please try it again and let me know if there are any other issues