Add missing type hint to EncodedVideo.from_path()'s return value#243
Open
abstractionmage wants to merge 1 commit intofacebookresearch:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If a user loads a video through the
EncodedVideo.from_pathmethod, they will not get any type hints for that video in their IDE because that method does not specify its return type. This PR fixes that.How Has This Been Tested
The method was called from another Python script. Since I just added a type hint and no syntax errors were raised, there's no possibility for anything to have broken.
Types of changes
Checklist