Skip to content

Fix missing BPE vocabulary asset in non-editable install#282

Closed
claydugo wants to merge 2 commits intofacebookresearch:mainfrom
claydugo:ship_assets
Closed

Fix missing BPE vocabulary asset in non-editable install#282
claydugo wants to merge 2 commits intofacebookresearch:mainfrom
claydugo:ship_assets

Conversation

@claydugo
Copy link

@claydugo claydugo commented Dec 2, 2025

Minimal Reproducer

pip install git+https://github.com/facebookresearch/sam3.git
python -c "
import os, sam3
bpe_path = os.path.join(os.path.dirname(sam3.__file__), '..', 'assets', 'bpe_simple_vocab_16e6.txt.gz')
print(f'Path: {bpe_path}')
print(f'Exists: {os.path.exists(bpe_path)}')  # False

https://github.com/facebookresearch/sam3/blob/84cc43bca4347b772f17/sam3/model_builder.py#L584

Including #167 in here as its required but we are applying that patch in the feedstock already.

This would PR would help us package for conda-forge.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2025
@claydugo
Copy link
Author

claydugo commented Dec 2, 2025

Applied to the conda-forge package in conda-forge/sam3-feedstock#2

@claydugo
Copy link
Author

Fixed in #327

@claydugo claydugo closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants