Fix: Add pandas to notebooks dependencies#310
Fix: Add pandas to notebooks dependencies#310harikapadia999 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Fixes facebookresearch#151 - ModuleNotFoundError when running sam3_image_predictor_example.ipynb The example notebook requires pandas but it was only listed in dev dependencies. Added pandas to the notebooks optional dependencies to resolve the import error.
|
Hi @harikapadia999! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| "einops", | ||
| "scikit-image", | ||
| "scikit-learn", | ||
| "pandas", |
There was a problem hiding this comment.
Not for you to address in this PR - but I am wondering if we may want to start pinning versions for the dependencies here.
Description
Fixes #151 - Resolves
ModuleNotFoundError: No module named 'pandas'when runningsam3_image_predictor_example.ipynbProblem
The example notebook
sam3_image_predictor_example.ipynbrequires pandas but it was only listed in thedevoptional dependencies, not innotebooksdependencies. Users installing withpip install -e ".[notebooks]"would encounter an import error.Solution
Added
pandasto thenotebooksoptional dependencies inpyproject.tomlTesting
Checklist