fix: replace 3 bare excepts with specific exception types#472
fix: replace 3 bare excepts with specific exception types#472haosenwang1018 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
- tokenizer_ve.py: except ValueError for str.index() lookup - download_preprocess_nga.py: except Exception for download errors - extract_frames.py: except Exception for image validation Bare except catches KeyboardInterrupt and SystemExit, masking real errors.
|
Hi @haosenwang1018! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Summary
Replace 3 bare
except:clauses with specific exception types.Changes
sam3/model/tokenizer_ve.py:except:→except ValueError:forstr.index()lookupscripts/eval/silver/download_preprocess_nga.py:except:→except Exception:for download error handlingscripts/eval/silver/extract_frames.py:except:→except Exception:for image validationWhy
Bare
except:catchesKeyboardInterruptandSystemExit, which can mask real errors and prevent clean process termination.