fix: preserve forward slashes in HF repo ID on Windows#11
Open
RAVINDRA8008 wants to merge 1 commit intofacebookresearch:mainfrom
Open
fix: preserve forward slashes in HF repo ID on Windows#11RAVINDRA8008 wants to merge 1 commit intofacebookresearch:mainfrom
RAVINDRA8008 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
On Windows, Path('facebook/tribev2') converts the forward slash to a
backslash, producing 'facebook\tribev2' when cast back to str().
This breaks huggingface_hub validation which expects forward slashes.
Fix: save the original checkpoint_dir string before converting to
Path, and use that preserved string as the HuggingFace Hub repo ID.
Closes facebookresearch#10
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10
On Windows,
Path("facebook/tribev2")converts the forward slash to a backslash, producing"facebook\tribev2"when cast back tostr(). This causeshuggingface_hub.errors.HFValidationErrorbecause the Hub expects forward slashes in repo IDs.Changes
tribev2/demo_utils.py-TribeModel.from_pretrained():checkpoint_dirstring before converting topathlib.Pathrepo_id