Guard plot_stimuli against missing audio / word events#47
Open
sepehrheravi wants to merge 1 commit intofacebookresearch:mainfrom
Open
Guard plot_stimuli against missing audio / word events#47sepehrheravi wants to merge 1 commit intofacebookresearch:mainfrom
sepehrheravi wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
BasePlotBrain.plot_stimuli crashed for silent or speechless clips because it unconditionally called audio.to_soundarray() and events.type. This made plot_timesteps(show_stimuli=True) unusable for screen recordings and any video where WhisperX produces zero words, even though main.py already handles the missing-modality case by auto-dropping the text extractor. - Plot the audio waveform only when get_audio(...) returns non-None. - Skip the word-overlay loop when segment.events is None or has no 'type' column. - Behaviour is unchanged when both modalities are present. Fixes facebookresearch#46
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plot_stimuli assumed every segment has audio and word events. Silent clips
and screen recordings have neither. main.py already auto-drops missing
extractors — this PR adds matching None-guards on the plotting side.
Changes
`tribev2/plotting/base.py`:
Test plan
now renders with blank audio/text panels and video frames.
Fixes #46