Fix: forward drop_last to make_videodataset#126
Fix: forward drop_last to make_videodataset#126laszloturanyi wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
|
Hi @laszloturanyi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Replaced np.linspace + padding with np.arange(fpc) * fstp in the allow_clip_overlap branch. linspace over (clip_len-1) frames produced non-integer steps (e.g. 5.64 for fstp=5) that alternated between 5 and 6 after int casting. arange gives exactly uniform steps of fstp; np.clip handles videos shorter than clip_len by repeating the last frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
The drop_last argument was not passed to make_videodataset(), which results in default behavior to drop remainder samples in case of validation dataset. This is more significant in case of small datasets.
This one-liner fixes this issue.