Replace string code templates with AST Builder provided by https://github.com/nikic/PHP-Parser#46
Open
Giuffre wants to merge 40 commits intofeature/phpunit7from
Open
Replace string code templates with AST Builder provided by https://github.com/nikic/PHP-Parser#46Giuffre wants to merge 40 commits intofeature/phpunit7from
Giuffre wants to merge 40 commits intofeature/phpunit7from
Conversation
Giuffre
changed the title
Giuffre
changed the title
Contributor
Author
|
In my opinion from now, we can proceed with the refactor of AST creators. We need to find a common logic to avoid duplications. @xzhavilla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, in order to remove code templates I'm trying to integrate the AST builder of PHP parser lib by Nikic.