Skip to content

feat: Refactor GitHub Actions workflows to use a reusable Docker build/push workflow #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rapoler wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Refactor GitHub Actions workflows to use a reusable Docker build/push workflow #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions .github/workflows/studio-releaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,11 @@ on:

jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set env
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- name: Login Docker Hub
run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u deshetti --password-stdin
- name: Build and push dega studio
uses: docker/build-push-action@v2
with:
push: true
tags: factly/dega-studio:${{ env.RELEASE_VERSION }}
context: studio
file: studio/Dockerfile.prod
uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Pin the reusable workflow to an immutable ref.

Line 9 uses @develop, so release behavior can drift with future changes in factly/gopie-ee and break reproducibility. For a release pipeline, this should be pinned to a version tag or commit SHA instead.

Suggested change 
-    uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop
+    uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@<immutable-tag-or-commit-sha>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop
uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@v1.2.3
Suggested change
uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop
uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@abc123def456
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/studio-releaser.yml at line 9, The reusable workflow
reference "uses:
factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop" is pinned to a
mutable branch; replace the `@develop` suffix with an immutable ref (a release tag
or a specific commit SHA) so the workflow is reproducible and cannot change
unexpectedly—update the "uses" line to point to a stable tag (e.g., `@vX.Y.Z`) or
a commit SHA instead of `@develop`.

with:
tags: asia-south1-docker.pkg.dev/factly-prod/dega/studio:${{ github.ref_name }}
context: studio
dockerfile: studio/Dockerfile.prod
permissions:
contents: read
id-token: write