Skip to content

Redux/tests#848

Closed
ishpaul777 wants to merge 18 commits intofactly:developfrom
ishpaul777:redux/tests
Closed

Redux/tests#848
ishpaul777 wants to merge 18 commits intofactly:developfrom
ishpaul777:redux/tests

Conversation

@ishpaul777
Copy link
Copy Markdown
Contributor

@ishpaul777 ishpaul777 commented Jan 24, 2023

This PR adds test coverage for the redux actions in our application. The tests include:

  • Unit tests for each action to ensure they are dispatching the correct type and payload
  • changes in update actions for issue explained below
 current entity = {
	...
	description: {
	json: { }
	html: ..
  }
	...
  }

entity.description = { json: entity.description, html: entity.description_html };=
//  after above it becomes
entity = {
	...
	description: {
	json: {
		json: { }
		html: ...
	}
	html: ..
  }
  ...
  }

Please take a look and let me know if there's anything that needs to be changed or if you have any questions.

Copy link
Copy Markdown
Contributor

@surajmn1 surajmn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777 please fix the test case for root reducer , only include the studio/src directory files and remove all files which do not have any changes related to the test cases .

@ishpaul777
Copy link
Copy Markdown
Contributor Author

@surajmn1 will do it!

@surajmn1 surajmn1 mentioned this pull request Jun 28, 2023
@surajmn1
Copy link
Copy Markdown
Contributor

closing this pr and opening a fresh one with merge conflicts fixed #903 .

@surajmn1 surajmn1 closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants