Avoid repeated logging of the same problem#14
Merged
rogercampos merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
oriolgual
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw an error running e2e locally. After investigation, the root cause was this: https://github.com/factorialco/factorial/pull/88951
However, before the real error the log also showed 8 different reports of errors from captain hook (see at the end). This is because the original error was an
ArgumentError, and although totally unrelated with that cause, this gem was rescuing, printing the log, and re-raising. Not only that, it did it 8 times, one per registered hook.I think there's no value in this rescue-log-reraise, if there's a problem let the exception bubble up and be reported normally, as any other kind of exception.