fix(CommunityPost): remove grey hover background from post card#3695
Open
ekaterina-spiridonova wants to merge 2 commits intomainfrom
Open
fix(CommunityPost): remove grey hover background from post card#3695ekaterina-spiridonova wants to merge 2 commits intomainfrom
ekaterina-spiridonova wants to merge 2 commits intomainfrom
Conversation
Remove hover:bg-f1-background-hover from the CommunityPost inner div so the card stays white on hover. The card-level hover shadow in the consuming app now provides the hover feedback instead.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CommunityPost card styling so it no longer applies an inner grey hover background, allowing the consuming app’s card-level hover shadow/visual treatment to remain consistent (white background on hover).
Changes:
- Removed
hover:bg-f1-background-hoverfrom theBaseCommunityPostroot container to prevent grey hover background. - Delegated hover feedback to the consuming wrapper/card level.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
109
to
113
| return ( | ||
| <div | ||
| className="flex w-full cursor-pointer flex-row gap-3 rounded-xl border border-solid border-transparent p-3 pt-2 hover:bg-f1-background-hover focus:border-f1-border-secondary focus:outline focus:outline-1 focus:outline-offset-1 focus:outline-f1-border-selected-bold md:pb-4 md:pt-3" | ||
| className="flex w-full cursor-pointer flex-row gap-3 rounded-xl border border-solid border-transparent p-3 pt-2 focus:border-f1-border-secondary focus:outline focus:outline-1 focus:outline-offset-1 focus:outline-f1-border-selected-bold md:pb-4 md:pt-3" | ||
| onClick={handleClick} | ||
| id={`community-post-${id}`} |
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
📦 Alpha Package Version PublishedUse Use |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚪 Why?
The community post cards now have card-level hover shadows applied by the consuming app (factorial). The inner
hover:bg-f1-background-hoverclass on the CommunityPost div causes a grey background on hover, which conflicts with the intended white card hover state.🔑 What?
hover:bg-f1-background-hoverfrom the outerdivclassName inBaseCommunityPost✅ Verification
Tests
Manual Verification