Skip to content

chore: support only expo sdk 54+ new arch#3697

Draft
developerdanx wants to merge 3 commits intomainfrom
feat/expo-sdk-54-export-for-new-architecture
Draft

chore: support only expo sdk 54+ new arch#3697
developerdanx wants to merge 3 commits intomainfrom
feat/expo-sdk-54-export-for-new-architecture

Conversation

@developerdanx
Copy link
Copy Markdown
Contributor

Description

  • support only expo sdk 54+ new arch

Copilot AI review requested due to automatic review settings March 19, 2026 09:13
@github-actions github-actions bot added chore react-native Changes affect packages/react-native labels Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

📦 Alpha Package Version Published

Use pnpm i github:factorialco/f0#npm/alpha-pr-3697-react-native to install the package

Use pnpm i github:factorialco/f0#c223d1c3a619f609239ee1cc8600919816270b8a to install this specific commit

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows @factorialco/f0-react-native support to Expo SDK 54+ and React Native New Architecture, updating dependencies and documentation accordingly.

Changes:

  • Update React Native peer dependency stack to Reanimated 4 + react-native-worklets and remove react-native-worklets-core.
  • Remove unused/development-only packages from packages/react-native and the lockfile.
  • Add/refresh docs describing New Architecture + Expo 54 host app requirements.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Reflects dependency removals and the updated Reanimated/Worklets stack.
packages/react-native/package.json Updates peer/dev deps for Expo SDK 54+ and Reanimated 4; removes old/unused deps.
packages/react-native/docs/new-architecture.md New documentation about New Architecture and Expo 54 compatibility/requirements.
packages/react-native/babel.config.cjs Adds an explicit plugins: [] entry alongside existing presets.
packages/react-native/README.md Documents the Expo 54+ / New Arch-only support and updates installation/config guidance.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

📱 Expo Go Preview Published

  • Branch: development
  • Message: Merge branch 'main' into feat/expo-sdk-54-export-for-new-architecture
  • Group ID: 9ccf61b6-ef5d-4c3a-951c-914d754ab8f4
  • Created at: 2026-03-31T11:54:49.438Z

Links

QR Code

Expo Go Preview QR

Copilot AI review requested due to automatic review settings March 31, 2026 11:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates @factorialco/f0-react-native to explicitly target Expo SDK 54+ with React Native New Architecture (Fabric/TurboModules), aligning dependency expectations and host-app setup docs accordingly.

Changes:

  • Update React Native package peer dependencies for the Expo SDK 54 / RN 0.81 stack (notably Reanimated 4 + react-native-worklets) and remove no-longer-used deps.
  • Expand/update React Native package documentation to state “New Architecture + Expo SDK 54+ only” and adjust setup steps.
  • Add a dedicated New Architecture compatibility/troubleshooting document.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-lock.yaml Lockfile updates reflecting dependency removals/bumps aligned with the new supported stack.
packages/react-native/README.md Documents New Architecture + Expo SDK 54+ support and updates installation/configuration guidance.
packages/react-native/package.json Updates peer deps to Reanimated 4 + react-native-worklets, removes unused deps.
packages/react-native/docs/new-architecture.md New doc describing compatibility expectations and host requirements/troubleshooting.
packages/react-native/babel.config.cjs Adds explicit empty plugins array in Babel config.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment on lines +34 to 49
# 2) Install Expo-native dependencies pinned to your SDK
npx expo install \
expo-image \
react-native-reanimated \
react-native-worklets \
react-native-safe-area-context \
react-native-svg
```

> **Note:** The following peer dependencies are required:
>
> - `uniwind` and `tailwindcss` - Required for styling (must be configured in Metro and CSS files)
> - `tailwind-merge` and `tailwind-variants` - Required for component variant system and class merging
> - `react-native-reanimated` - Required for animations
> - `react-native-worklets` - Required by Reanimated 4
> - `react-native-safe-area-context` - Required for safe area handling
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Quick Setup install instructions omit expo-blur, but expo-blur is listed as a required peer dependency in packages/react-native/package.json and is imported by F0BlurView. This can lead to runtime/module resolution errors for consumers following the README. Please add expo-blur to the npx expo install list (and ideally to the “required peer dependencies” bullet list).

Copilot uses AI. Check for mistakes.
| `react-native-reanimated` | `^4.1.0` | ✅ Yes | Animations |
| `react-native-worklets` | `>=0.5.0 <1.0.0` | ✅ Yes | Worklet runtime for Reanimated 4 |
| `react-native-safe-area-context` | `^5.6.0` | ✅ Yes | Safe area handling |
| `react-native-svg` | `^15.12.1` | ✅ Yes | SVG support for icons |
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The “Peer Dependencies” table is missing expo-image and expo-blur, even though both are required peer dependencies in packages/react-native/package.json and are directly imported in primitives (F0Image, F0BlurView). The table should list them to prevent incomplete host setup.

Suggested change
| `react-native-svg` | `^15.12.1` | ✅ Yes | SVG support for icons |
| `react-native-svg` | `^15.12.1` | ✅ Yes | SVG support for icons |
| `expo-image` | `*` | ✅ Yes | Image component for primitives |
| `expo-blur` | `*` | ✅ Yes | Blur view for primitives |

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore react-native Changes affect packages/react-native

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants