feat(F0Box): address hoverBackground review feedback#3739
Draft
Copilot wants to merge 3 commits intofeat/f0box-hover-backgroundfrom
Draft
feat(F0Box): address hoverBackground review feedback#3739Copilot wants to merge 3 commits intofeat/f0box-hover-backgroundfrom
Copilot wants to merge 3 commits intofeat/f0box-hover-backgroundfrom
Conversation
Add a new `hoverBackground` prop to F0Box that exposes the 6 hover background tokens defined in @factorialco/f0-core but previously missing from the component API: - default (bg hover) - secondary (bg secondary hover) - accent-bold (bg accent bold hover) - promote (bg promote hover) - selected (bg selected hover) - selected-bold (bg selected bold hover) Each value applies the corresponding `hover:bg-f1-background-*-hover` Tailwind class along with `transition-colors` for smooth state changes.
5 tasks
…sition Co-authored-by: AngelMsaa <90286990+AngelMsaa@users.noreply.github.com> Agent-Logs-Url: https://github.com/factorialco/f0/sessions/9e71c013-4726-481a-849e-5784b23604fe
Copilot
AI
changed the title
[WIP] Add hoverBackground prop to F0Box with semantic tokens
feat(F0Box): address hoverBackground review feedback
Mar 24, 2026
AngelMsaa
force-pushed
the
feat/f0box-hover-background
branch
from
5eb9059 to
0591663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues with the initial
hoverBackgroundimplementation flagged in review: missing public type export,transition-colorsduplicated across every variant value, and the prop not usable via responsive breakpoint overrides.Changes
index.tsx— re-exportHoverBackgroundTokenalongside the other token types (alphabetically afterGapToken)background.ts— striptransition-colorsfrom each variant string; it was repeated 6× with no single source of truthF0Box.tsx— applytransition-colorsonce viahoverBackground && "transition-colors"in thecn()callresponsive.ts— addhoverBackground?: HoverBackgroundTokentoResponsiveStylePropsresponsive-safelist.ts— add{sm,md,lg,xl}:hover:bg-f1-background-*-hoverentries for Tailwind JITResponsive usage now supported
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.