Merged
Conversation
LGTM!| uses: string; | ||
| with?: Record<string, string | number | boolean | object>; | ||
| secrets?: Record<string, string | number | boolean | object> | "inherit"; | ||
| environment?: string; |
There was a problem hiding this comment.
better set a default value, like the above "inherit"? How does it affect existing workflows?
Contributor
Author
There was a problem hiding this comment.
existing workflows work as is, no change.
Contributor
There was a problem hiding this comment.
@arnauvp-factorial That's not a default value, that's part of the type 👍 . In case of environment since it is a string, there is no specific string for that type.
arnauvp-factorial
approved these changes
Jun 17, 2025
heyrun
force-pushed
the
allow_enviornment_settings_on_job
branch
from
fdb905a to
85174e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚪 Why?
🔑 What?
🏡 Context