Skip to content

Conversation

@Stargator
Copy link

  • AngularJS 1.3 seems to break the build - so changed versions in bower.json to ~1.2.x
  • No tmp dependency defined in package.json - It has to be 0.0.23 otherwise any higher and the build breaks
  • Spec test "defaults to using the translate service, if available" is a test that doesn't seem to be working as intended. If translate is off, @facultymatt should it return back "Hello"?

This would resolve the build issues on Travis CI.

AngularJS 1.3 seems to break the build - so changed versions in bower.json to ~1.2.x
No tmp dependency defined in package.json - It **has to be 0.0.23** otherwise any higher and the build breaks
@Stargator Stargator changed the title Pulling AngularJS verson down to 1.2.x and added tmp dependency Fix Failing Builds - By pulling AngularJS version down to 1.2.x and added tmp dependency Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant