Fix error handling for v2.0#12
Merged
fadion merged 2 commits intofadion:masterfrom Jun 25, 2018
Nacoma:master
Merged
Conversation
added 2 commits
June 4, 2018 13:11
Making sure to not track IDE specific directories/files.
The v2 API response contains additional properties to indicate a successful response. The previous version used a string property `error` that is now an array containing an error code and description. These changes extract the code and description in order to properly construct the `ResponseException`.
Contributor
Author
|
This should close #10 as well |
Owner
|
Sorry for the big delay in merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests have been updated. See commit messages for more detail.