Skip to content

call_hook: honor $STOP_ON_ERROR when an executed hook sets task_error #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peturingi wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

call_hook: honor $STOP_ON_ERROR when an executed hook sets task_error #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/subroutines
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ call_hook() {
local hook=$1
shift

local cl dflag hfile
local cl dflag hfile te
[ "$debug" ] && dflag="-d"

for cl in $classes; do
Expand Down Expand Up @@ -383,6 +383,12 @@ call_hook() {
# execute the hook
$hfile $dflag "$@"
check_status $hook.$cl $?
te=$(< $LOGDIR/task_error)
if [ "$te" -gt "$STOP_ON_ERROR" ]; then
task_error=$te
task_error_func=$hook.$cl
stop_fai_installation
fi
fi
done
}
Expand Down