fai-do-scripts: stop at the first script exceeding $STOP_ON_ERROR#136
Open
peturingi wants to merge 1 commit intofaiproject:masterfrom
Open
fai-do-scripts: stop at the first script exceeding $STOP_ON_ERROR#136peturingi wants to merge 1 commit intofaiproject:masterfrom
peturingi wants to merge 1 commit intofaiproject:masterfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fai-do-scriptsruns every script in a class directory and only returns an aggregate exit (100 + maxstatus) at the end.task_configureonly then callstask_error 420 $?, which is where$STOP_ON_ERRORis consulted. As a result, settingSTOP_ON_ERROR=1does not prevent later scripts from running after one fails — the threshold is effectively only checked at the task boundary.This change checks the offset exit value against
$STOP_ON_ERRORinsidesavemaxstatusand aborts immediately when exceeded. The offset (100 + exitcode) matches whatfai-do-scriptswould have returned at the end, so callers see the same final exit code. With the defaultSTOP_ON_ERROR=700nothing changes in practice; only configurations that lower the threshold see the new per-script abort.