fix(s3): ListBuckets v2 — BucketRegion + prefix/region/pagination filters#820
Merged
vieiralucas merged 1 commit intomainfrom Apr 28, 2026
Merged
fix(s3): ListBuckets v2 — BucketRegion + prefix/region/pagination filters#820vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
…ters Closes #816. ListBuckets response previously omitted <BucketRegion> per entry, which the VS Code AWS Toolkit uses to filter visible buckets — buckets created through fakecloud were hidden in the IDE explorer. The AWS CLI tolerates the missing field, but real S3 always emits it. This fixes the symptom and rounds out the full ListBuckets v2 surface that AWS shipped alongside BucketRegion: - Per-bucket <BucketRegion> in every response - prefix query parameter — filter buckets by name prefix - bucket-region query parameter — filter buckets by region - max-buckets query parameter (1..=10000, default 10000) — page size - continuation-token query parameter — opaque base64 cursor - <ContinuationToken> response element — next-page cursor when truncated - <Prefix> / <BucketRegion> echoed in response when input had them - InvalidArgument errors for out-of-range max-buckets and malformed tokens Coverage: 7 unit tests in fakecloud-s3 (region in body, region filter, prefix filter, pagination, continuation resume, invalid max-buckets, invalid token) and 4 e2e tests via aws-sdk-s3 (region populated, pagination across pages, prefix filter, region filter with mixed-region buckets). Conformance ListBuckets checksum unchanged — Smithy model already declared the v2 fields.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #816.
ListBuckets response was missing
<BucketRegion>per entry, which the VS Code AWS Toolkit uses to filter visible buckets — fakecloud buckets were hidden in the IDE explorer. AWS CLI tolerates the missing field, real S3 always emits it.While fixing this, rounded out the full ListBuckets v2 surface AWS shipped alongside
BucketRegion:<BucketRegion>per bucket entryprefixquery parameter — name-prefix filterbucket-regionquery parameter — region filtermax-bucketsquery parameter (1..=10000, default 10000) — page sizecontinuation-tokenquery parameter — opaque base64 cursor<ContinuationToken>response element — next-page cursor when more pages remain<Prefix>/<BucketRegion>echoed in response when input had themInvalidArgumenterrors for out-of-range max-buckets and malformed tokensTest plan
fakecloud-s3: 7 new tests covering all behaviorsaws-sdk-s3: 4 new tests (region populated, pagination across pages, prefix filter, region filter with mixed-region buckets)s3_bucket_lifecyclestill passes — Smithy checksum unchangedcargo clippy --workspace --all-targets -- -D warningscleancargo fmt --allcleanwebsite/static/llms-full.txtupdated to note v2 pagination + filtersSummary by cubic
Implements S3 ListBuckets v2 with per-bucket
BucketRegion, filters, and pagination. Fixes VS Code AWS Toolkit bucket visibility to match real S3 (closes #816).BucketRegioninListBucketsresponses.prefix,bucket-region,max-buckets(1..10000, default 10000),continuation-token(base64). Adds<ContinuationToken>when more pages remain.<Prefix>and<BucketRegion>when provided. ReturnsInvalidArgumentfor out-of-rangemax-bucketsor malformed tokens.Written for commit e3d215d. Summary will update on new commits. Review in cubic