CMake and internal editline update #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
astrorigin
commented
Mar 26, 2023
astrorigin
commented
- Update CMake minimum version to 3.16.3 (Ubuntu FF)
- Update internal editline library
- Fix FindEditline.cmake so that it can actually find libreadline when requested
Also made the module more readable.
jonnymind
approved these changes
Dec 26, 2023
Member
|
Need to be rebased on your fork, then I'll merge it. |
|
@jonnymind Hi, part of this pr is needed to fix the build of your project on nixpkgs (cmake4 compatibility). Since it has stayed without update for 2 years without @astrorigin answer, i wanted to know if you would be interested in me opening a new pr for it.
|
13 tasks
Member
|
Sure, mate. I got a few things on my hands right now, but I'll keep an eye open. Please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.