Modernize dependencies and add comprehensive edge-case tests#5
Merged
Modernize dependencies and add comprehensive edge-case tests#5
Conversation
…corn verification Update all dependencies to latest versions: - falcon 0.5.2 → 0.6.0, falcon-z3 0.5.2 → 0.6.0 - clap 2 → 4, nom 6 → 8, rustyline 9 → 17, goblin 0.4 → 0.10 - byteorder 1.3 → 1.5, lazy_static 1.4 → 1.5, simplelog 0.10 → 0.12 - Remove falcon_capstone, rayon, unicorn dependencies Adapt codebase to new dependency APIs (clap 4 builder, nom 8 parsers, rustyline 17, falcon 0.6 IL changes including AShr support). Remove unicorn_verify_*.rs modules (unicorn dependency removed). Add 63 new edge-case tests across Memory, State, simplify, and FileSystem covering byte ordering, page boundaries, backing memory, symbolic roundtrips, Z3 solver paths, merge operations, execute operations, and filesystem I/O. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falcon_capstone,rayon,unicorn; deleteunicorn_verify_amd64.rs,unicorn_verify_mips.rs,unicorn_verify_x86.rsTest coverage added
Memory (15 tests)
Byte ordering (LE/BE), page boundary crossing, partial uninitialized loads, backing memory fallback, page-overrides-backing, permission alignment validation, flatten (concrete→backing, symbolic stays), merge (differing→ITE, identical unchanged), symbolic store/load roundtrip, load_buf partially uninitialized, initialize_blank
Simplify (6 tests)
And+bitmask eliminates zext via Or, preserves wider zext, trun eliminates upper Or bits, trun/zext different-bits no-collapse, or-zero identity, idempotency
State (22 tests)
Scalar not set, nested symbolization, eval constant fast path, unsatisfiable→None, eval_and_concretize (adds constraint for symbolic / skips for constant), symbolize_and_assert (satisfiable/unsatisfiable/constant true/false), execute (assign/store/load-uninitialized/undefined-scalar-in-index/branch/nop/intrinsic-error), make_symbolic_buffer, make_symbolic_string null termination, get_string, merge (differing/same/extra scalars), expression_complexity_variable
FileSystem (17 tests)
stdin/stdout/stderr creation, duplicate fd, read at EOF, short reads, seek (Set/Cursor/End), write past EOF with zero fill, write to nonexistent (with/without offset), close_fd (reclaim highest/gap no-reclaim/invalid), fd_valid after close, zeroize, size_fd invalid, write_fd extends file
Test plan
cargo fmt— no formatting issuescargo clippy --all-targets— no new warningscargo test— all 88 tests pass🤖 Generated with Claude Code