Open
Conversation
Trades fees were added to the portfolio_purchase_price instead of removed which led to an overestimated portfolio_purchase_price. Easily testable with : BUY BTC 1 1000 EUR,1000 10 SELL BTC 0.375 1200 EUR 450.0 3 SELL BTC 0.625 2080 EUR 1300 7 Without the patch : [portfolio_purchase_price_net] = 1010 With the patch : [portfolio_purchase_price_net] = 990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trades fees were added to the portfolio_purchase_price instead of removed which led to an overestimated portfolio_purchase_price.
Easily testable with :
Without the patch : [portfolio_purchase_price_net] = 1010
With the patch : [portfolio_purchase_price_net] = 990