Fixes #7 partially#41
Open
arttumiettinen wants to merge 3 commits intofangq:masterfrom
Open
Conversation
added 3 commits
January 3, 2020 10:44
…on in cgalmesh with the custom initialization by Laurent Irineau.
…on in cgalmesh with the custom initialization by Laurent Irineau.
lrineau
approved these changes
Jan 3, 2020
Owner
|
thanks @lrineau, sorry for taking this long, had been overwhelmed by department services at the beginning of the semester, and finally have time to start working on iso2mesh. I just tried to compile your updated source codes on my Ubuntu 16.04 machine (with cgal 4.7) , but it failed with the following error message is this path specific for cgal 5? can the code accommodate other cgal releases by placing #ifdef macros? thanks |
Contributor
|
The file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick and dirty fix for cgalmesh part of issue #7 (missing regions in cgalmesh output). Support for non-uint8 images and >256 regions is also included. This is probably just a starting point for complete fix but maybe it helps anyway.