fix: sanitize search snippets to prevent XSS from indexed summaries#2
Open
fix: sanitize search snippets to prevent XSS from indexed summaries#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
meetings_fts.transcript_textcolumn which is later used by SQLitesnippet()and returned as raw HTML.dangerouslySetInnerHTMLwithout sanitization, creating an XSS vector if a summary contains HTML/JS.Description
sanitizeSearchSnippetHtmltosrc/views/LibraryView.tsxwhich HTML-escapes snippet content and then allowlists the<mark>tag so FTS highlight markup still renders.renderSearchSnippetto return sanitized HTML via the new sanitizer while preserving existingdangerouslySetInnerHTMLusage.Testing
npm testwhich completed successfully (14tests passed).npm run build; the first build failed due to use ofString.replaceAll, then the sanitizer was adjusted to use regexreplacecalls and the subsequentnpm run buildsucceeded.src/views/LibraryView.tsxand that search UI still renders with highlight marks while snippet content is escaped.Codex Task