Skip to content

Updated javascript in MediaAccess #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alettieri wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated javascript in MediaAccess #63

alettieri wants to merge 3 commits into from

Conversation

@alettieri
Copy link

@alettieri alettieri commented Feb 6, 2013

Made an attempt at cleaning up the JS a bit.

Summary

  • Did away with the object literal setting in the class attribute and moved it to the data attribute. Labels can now be parsed using jQuery.data instead of regular expression on the class attribute.
  • Also did away with using setInterval. Modified the workflow to a pub/sub model.
  • Did away with jQuery.live and went with event delegation instead. Document listens for the click event and delegates it down to the MediaAccess button.
  • Added upload support when editor is not present on the screen. Good case for custom post types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alettieri @farinspace