Conversation
* fix: clippy issue * fix: example panic when start * fix: runtime should not be emitted twice for a single bundle
fix: tree shake, HMR and source map issues
* fix(schema): invalid server schema with types * chore: optimize types and schema --------- Co-authored-by: ADNY <66500121+ErKeLost@users.noreply.github.com>
* feat: add js plugin freeze_modules hooks * chore: remove unless code * chore: update code * chore: remove format * chore: update code * chore: update types * chore: update code * chore: update code * chore: update code * chore: update code * chore: add module_hook_common
* chore: write generate resource moves into rust side * chore: update generate resource write * feat: add rust plugin file size * chore: update file-size plugins * chore: update file-size plugins * chore: update code * chore: update code * chore: rewrite writeResourceToDisk * chore: remove unless file * chore: remove file size in farm crate * chore: remove file size in farm crate * chore: remove file size in farm crate * chore: add schema
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…/farm into feat/rewrite-create-farm
|
I think we should try not to make things too complicated, such as |
|
@ErKeLost Personally, I think the role of CLI tools is to save the user as much time as possible, and integrating tasks that may need to be performed in a CLI tool can help the user start a new project faster. In fact, in addition to making it clearer to maintain our CLI tools, the new architecture also makes it easier to expand the functionality of As you can see, special customizations are also done in We could also follow this design, which would allow users to explore many of Farm's features earlier. In my vision, I would add some interesting optional generic plugins to I followed the user needs oriented basis in the new refactoring to create less extraneous code while helping users with more tasks in the CLI tools. In the Git initialization task, I bind the Of course, if you're sure we don't need to do that, I'll change the code later. |
|
On the one hand, since we are a basic framework, we should ensure user friendliness as much as possible, enabling students who are just starting to learn front-end development, for example, to use and understand the functions of this framework more quickly starter. |
|
@ErKeLost Thanks for the advice, I know what u are thinking abount but I still reserve my opinion. I asked some working front-end engineers for their opinion in order to solve this problem, and it looks like the problem exists in both of the scenarios we mentioned. Some engineers prefer a strong scaffolding, but some of my friends (who may be using farm for the first time or are new to front-end development) object to the complexity this may bring. Maybe we could use a compromise solution, such as letting users choose whether to go further or not, which would triage users: for those who want to test something or get up to speed with farm as soon as possible, they could choose no at this step, and for the other group of users who choose yes, our WDYT? I think this could both avoid the complexity for new comers and get better user exprience for advanced users which can improve the user friendliness. |
|
I personally think this might not be what the create farm needs to do. If more powerful features are required, we can simply start a new scaffolding to handle these. This kind of issue is rather subjective. I also know that everyone will have different views. Everyone bases their opinions on their own experiences. We can ask for everyone's opinions. |
|
I'll be moving forward with this one, and next I'll be placing all the other miscellaneous tasks after asking the user if they've decided to continue, as a way of accommodating the usage preferences of different user types. |
Resolved: #2091
Roadmap
Refactor chore works after asking users
Other chore works
Auto detect if a project exists, if the project is based on Vite or Rspack, ask user to migrate to farm.
Current works like