✨ Add --reload-dir option
#160
Conversation
JoelYoung01
changed the title
|
Looks like I can't add labels. Figured maybe the autolabeler read the emojis lol, that would be neat. Everything else should be fine, just need a label to be added. |
|
thats not it #36 i even tried to fix auto labeler.. with no luck |
|
Womp womp for us I guess haha. Guessing @tiangolo has to add labels himself (or anyone with accesss I suppose) |
|
Just wanna say it'd be awesome if this got merged in! I was thinking about writing a PR to do exactly this, then I saw it was already done :) |
|
Revisiting this PR to see if anything has changed. Just to make sure I'm not blind or something I tried adding labels via the gh cli, got this error: gh pr edit 160 --add-label feature
GraphQL: JoelYoung01 does not have the correct permissions to execute `AddLabelsToLabelable` (addLabelsToLabelable)Would love to see this merged! |
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
bot
added
the
conflicts
|
This is really needed. Would be great if this could be merged! |
github-actions
bot
removed
the
conflicts
YuriiMotov
changed the title
reload-dir option
|
Money |
There was a problem hiding this comment.
LGTM!
Should we also add --reload-delay, --reload-include, and --reload-exclude options?
https://uvicorn.dev/settings/#development
|
Sure! I can do that in a couple hours when I am back home, if you want! Or you can just send it too! |
|
Let's wait for Sebastian to review this. |
Added the ability to pass reload-dir option to uvicorn run command.