-
-
Notifications
You must be signed in to change notification settings - Fork 65
🐛 Fetch the documentation URL dynamically #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
becbe1e
to
dfec882
Compare
dfec882
to
fb3ee8e
Compare
Do you think this is a good approach @tiangolo ? 🙏🏻 |
@tiangolo I do not have permission to configure a label for the PR. https://github.com/fastapi/fastapi-cli/actions/runs/10408815023/job/28827030912?pr=24 |
I ran across the same bug today and I can confirm that the provided patch resolves the issue. |
This pull request has a merge conflict that needs to be resolved. |
@chipytux , thank you for your interest and efforts! This PR needs to be updated to reflect latest changes. Would you like to work on this? |
Hi, this sounds interesting. Could you tell me more about what exactly needs to be done? |
oh, ok, I'm able to handle these changes since @chipytux isn't aware of it cc: @YuriiMotov |
I meant we need to resolve the merge conflicts (merge The |
Pull Request Description
Title: Fetch docs_url dynamically from FastAPI app
Description:
This pull request introduces a change to the
fastapi-cli
library that fetches thedocs_url
value dynamically from the FastAPI application instead of using a hardcoded value.Implementation Details:
The change involves modifying the
_run
function to fetch thedocs_url
value from the FastAPI application using theapp.openapi_url
attribute. This ensures that the library always uses the URL specified by the application itself.Testing:
The updated function has been thoroughly tested to ensure it correctly retrieves the
docs_url
value from the FastAPI application and show the appropriate URL.